Skip to content

Conversation

@aleksandar-terziev
Copy link
Contributor

@aleksandar-terziev aleksandar-terziev commented Dec 12, 2025

JIRA - BGSOFUIRILA-4149

Replace hardcoded Slider and RangeSlider positioning values with calculated CSS formulas across all themes to align with design spec

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Dec 12, 2025

🧹 Preview deployment cleaned up: https://pr-12802--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 12, 2025 17:17 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 22, 2025 15:40 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 22, 2025 17:13 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 23, 2025 16:14 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 29, 2025 07:51 Inactive
@nikoletavnv
Copy link
Contributor

nikoletavnv commented Jan 5, 2026

I still see misalignment of the progress indicator and the slider track. The progress is now rendered a little bit above the track.
The issue is present at certain magnifications e.g. 150% or 175% and disappears on 200%

Please check this picture in Cozy mode:
image

In Compact mode the misalignment is less but still noticeable.

@github-actions github-actions bot added the Stale label Jan 20, 2026
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 21, 2026 16:12 Inactive
@github-actions github-actions bot removed the Stale label Jan 22, 2026
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 26, 2026 07:45 Inactive
@nikoletavnv
Copy link
Contributor

On sap_fiori_3 and sap_fiori_3_dark there is a little shift of the left progress:
image

@nikoletavnv
Copy link
Contributor

On sap_horizon_hcw the focus outline of the handle is somehow shifted:

image

@nikoletavnv
Copy link
Contributor

On sap_horizon and sap_horizon_dark - the slider progress focus ::after is almost overlapping the right handle when the range slider is moved to the right end of the scale:

image

Copy link
Contributor

@nikoletavnv nikoletavnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good in general. We can discuss to what extent we can fix the small visual issues that I found during the code review.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 26, 2026 17:53 Inactive
@aleksandar-terziev
Copy link
Contributor Author

The change looks good in general. We can discuss to what extent we can fix the small visual issues that I found during the code review.

Thanks for the review! I have addressed the issues mentioned in the comments.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 27, 2026 09:34 Inactive
@aleksandar-terziev aleksandar-terziev merged commit e3b27c2 into main Jan 27, 2026
20 of 22 checks passed
@aleksandar-terziev aleksandar-terziev deleted the align-slider-specs branch January 27, 2026 10:22
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 27, 2026 10:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants